Secret manager: Passwords - #68
Merged
Merged
Conversation
akremenetsky
force-pushed
the
feat/kms
branch
2 times, most recently
from
June 25, 2025 20:45
6a57b23 to
dc176c9
Compare
akremenetsky
marked this pull request as ready for review
June 25, 2025 20:45
phantomii
requested changes
Jun 26, 2025
akremenetsky
force-pushed
the
feat/kms
branch
4 times, most recently
from
June 29, 2025 14:28
53fbfbc to
c306bc5
Compare
phantomii
approved these changes
Jun 29, 2025
Added the initial part of Secret Manager to manager passwords. The first implementation is supported only plain passwords but a particular `constructor` interface allow to implement more strict solutions in the future. The secret manager follows the universal agent way so actual password generation and saving is on the driver side. Single driver `PasswordCapabilityDriver' has been added in the first implementation that uses the PG database as a storage for passwords. An example, of adding a password: Request: ```curl curl --location 'http://10.20.0.2:11010/v1/secret/passwords/' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer <TOKEN>' \ --data '{ "name": "my-password", "project_id": "c27f59fe-d3d3-4625-804c-5c9fd3bb3142", "method": "AUTO_HEX", "constructor": { "kind": "plain" } }' ``` Response: ```curl { "uuid": "985dad4b-161c-432c-8d9f-be78763df758", "created_at": "2025-06-25T20:39:50.095203Z", "updated_at": "2025-06-25T20:39:56.335798Z", "project_id": "c27f59fe-d3d3-4625-804c-5c9fd3bb3142", "name": "my-password", "description": "", "method": "AUTO_HEX", "status": "ACTIVE", "constructor": { "kind": "plain" }, "value": "755eca35ece5bd921852c72996d1a790" } ``` There are two supported method for generation: AUTO_HEX, AUTO_URL_SAFE Other improvements: - Significant fixes for the configuraiton service, integration with SDK. - Fixes for Element Manager for integration with universal agent. - A tiny fix for DNS for tests. Signed-off-by: Anton Kremenetsky <anton.kremenetsky@gmail.com>
gmelikov
approved these changes
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the initial part of Secret Manager to manager passwords. The first implementation is supported only plain passwords but a particular
constructorinterface allow to implement more strict solutions in the future. The secret manager follows the universal agent way so actual password generation and saving is on the driver side. Single driver `PasswordCapabilityDriver' has been added in the first implementation that uses the PG database as a storage for passwords. An example, of adding a password:Request:
Response:
There are two supported method for generation: AUTO_HEX, AUTO_URL_SAFE
Other improvements:
- Significant fixes for the configuraiton service, integration with SDK.
- Fixes for Element Manager for integration with universal agent.
- A tiny fix for DNS for tests.